src: store onread callback in internal field #26837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives a slight performance improvement. At 2000 runs:
confidence improvement accuracy (*) (**) (***)
net/net-c2s.js dur=5 type='buf' len=64 *** 0.54 % ±0.16% ±0.21% ±0.27%
nodejs-github-bot
added
c++
joyeecheung
approved these changes
Mar 21, 2019
jasnell
approved these changes
Mar 21, 2019
bnoordhuis
approved these changes
Mar 21, 2019
src/base_object-inl.h
Outdated
| v8::Local<v8::Value> value, | ||
| const v8::PropertyCallbackInfo<void>& info) { | ||
| // This could be e.g. value->IsFunction(). | ||
| CHECK_IMPLIES(typecheck != nullptr, ((*value)->*typecheck)()); |
There was a problem hiding this comment.
Since typecheck is never nullptr currently, maybe change the CHECK_IMPLIES into a simple CHECK?
You could also remove the default template argument and have a second, single-arg InternalFieldSet() without a check.
There was a problem hiding this comment.
Yeah, I’ve turned it into a simple CHECK and removed the nullptr default. We can always adjust this if we want.
addaleax
added
the
author ready
|
Landed in 3018441 |
addaleax
added a commit
that referenced
this pull request
Mar 26, 2019
This gives a slight performance improvement. At 2000 runs:
confidence improvement accuracy (*) (**) (***)
net/net-c2s.js dur=5 type='buf' len=64 *** 0.54 % ±0.16% ±0.21% ±0.27%
PR-URL: #26837
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
This gives a slight performance improvement. At 2000 runs:
confidence improvement accuracy (*) (**) (***)
net/net-c2s.js dur=5 type='buf' len=64 *** 0.54 % ±0.16% ±0.21% ±0.27%
PR-URL: nodejs#26837
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
This gives a slight performance improvement. At 2000 runs:
confidence improvement accuracy (*) (**) (***)
net/net-c2s.js dur=5 type='buf' len=64 *** 0.54 % ±0.16% ±0.21% ±0.27%
PR-URL: #26837
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives a slight performance improvement. At 2000 runs:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes