test: refactor test-dgram-broadcast-multi-process #26846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add check that `signal` is not null in callback. * Use arrow functions for callbacks, destructuring where appropriate, and a trailing comma in multi-line arrays
richardlau
approved these changes
Mar 22, 2019
cjihrig
approved these changes
Mar 22, 2019
Trott
added
the
author ready
himself65
requested changes
Mar 22, 2019
| const LOCAL_BROADCAST_HOST = '255.255.255.255'; | ||
| const TIMEOUT = common.platformTimeout(5000); | ||
| const messages = [ | ||
| Buffer.from('First message to send'), | ||
| Buffer.from('Second message to send'), | ||
| Buffer.from('Third message to send'), | ||
| Buffer.from('Fourth message to send') | ||
| Buffer.from('Fourth message to send'), |
There was a problem hiding this comment.
From https://eslint.org/docs/rules/comma-dangle:
Trailing commas simplify adding and removing items to objects and arrays, since only the lines you are modifying must be touched. Another argument in favor of trailing commas is that it improves the clarity of diffs when an item is added or removed from an object or array:
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/21775/ |
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/21784/ |
|
Landed in 8330555 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 24, 2019
* Add check that `signal` is not null in callback. * Use arrow functions for callbacks, destructuring where appropriate, and a trailing comma in multi-line arrays PR-URL: nodejs#26846 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
* Add check that `signal` is not null in callback. * Use arrow functions for callbacks, destructuring where appropriate, and a trailing comma in multi-line arrays PR-URL: nodejs#26846 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
* Add check that `signal` is not null in callback. * Use arrow functions for callbacks, destructuring where appropriate, and a trailing comma in multi-line arrays PR-URL: #26846 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
signalis not null in callback.and a trailing comma in multi-line arrays
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes