Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update dependencies in lint-md-cli-rollup #26889

Closed
wants to merge 1 commit into from
Closed

tools: update dependencies in lint-md-cli-rollup #26889

wants to merge 1 commit into from

Conversation

watilde
Copy link
Member

@watilde watilde commented Mar 24, 2019

Summary

  • Update @zeit/ncc to ^0.16.1 from ^0.15.2
  • Update unified-engine to ^6.0.1 from ^5.1.0
  • Run npm audit fix

Refs:

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@watilde build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3023/pipeline

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 24, 2019
@Trott
Copy link
Member

Trott commented Mar 24, 2019

Can you run npm run build-node as well so it generates the new file and we can see that it works (via CI)?

@watilde
Copy link
Member Author

watilde commented Mar 25, 2019

@Trott That's right. I included now.

@Trott
Copy link
Member

Trott commented Mar 25, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3030/

BridgeAR
BridgeAR approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 25, 2019
Trott
Trott approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@targos
Copy link
Member

targos commented Mar 30, 2019

Landed in ef0701d

@targos targos closed this Mar 30, 2019
targos pushed a commit that referenced this pull request Mar 30, 2019
@watilde @targos
tools: update dependencies in lint-md-cli-rollup
ef0701d 
Summary
+ Update `@zeit/ncc` to `^0.16.1` from `^0.15.2`
+ Update `unified-engine` to `^6.0.1` from `^5.1.0`
+ Run `npm audit fix`
+ Run `npm run build-node`

Refs:
+ https://github.com/unifiedjs/unified-engine/releases/tag/6.0.0
+ https://github.com/unifiedjs/unified-engine/releases/tag/6.0.1
+ https://github.com/zeit/ncc/releases/tag/0.16.0
+ https://github.com/zeit/ncc/releases/tag/0.16.1

PR-URL: #26889
Refs: https://github.com/unifiedjs/unified-engine/releases/tag/6.0.0
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
@watilde watilde deleted the deps/update branch April 1, 2019 06:27
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@watilde @BethGriggs
tools: update dependencies in lint-md-cli-rollup
98831a9 
Summary
+ Update `@zeit/ncc` to `^0.16.1` from `^0.15.2`
+ Update `unified-engine` to `^6.0.1` from `^5.1.0`
+ Run `npm audit fix`
+ Run `npm run build-node`

Refs:
+ https://github.com/unifiedjs/unified-engine/releases/tag/6.0.0
+ https://github.com/unifiedjs/unified-engine/releases/tag/6.0.1
+ https://github.com/zeit/ncc/releases/tag/0.16.0
+ https://github.com/zeit/ncc/releases/tag/0.16.1

PR-URL: #26889
Refs: https://github.com/unifiedjs/unified-engine/releases/tag/6.0.0
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@watilde @BethGriggs
tools: update dependencies in lint-md-cli-rollup
dc9ce86 
Summary
+ Update `@zeit/ncc` to `^0.16.1` from `^0.15.2`
+ Update `unified-engine` to `^6.0.1` from `^5.1.0`
+ Run `npm audit fix`
+ Run `npm run build-node`

Refs:
+ https://github.com/unifiedjs/unified-engine/releases/tag/6.0.0
+ https://github.com/unifiedjs/unified-engine/releases/tag/6.0.1
+ https://github.com/zeit/ncc/releases/tag/0.16.0
+ https://github.com/zeit/ncc/releases/tag/0.16.1

PR-URL: #26889
Refs: https://github.com/unifiedjs/unified-engine/releases/tag/6.0.0
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@hiroppy hiroppy hiroppy approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@watilde @nodejs-github-bot @Trott @targos @hiroppy @BridgeAR