Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: mark settings as optional and add callback #26894

Closed
wants to merge 1 commit into from
Closed

doc: mark settings as optional and add callback #26894

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

The settings are currently not required and the callback was not
documented so far.

This is an alternative to #26811.

Refs: #26811

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
doc: mark settings as optional and add callback
397139a 
The settings are currently not required and the callback was not
documented so far.

Refs: nodejs#26811
@BridgeAR BridgeAR requested a review from jasnell March 24, 2019 22:56
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3027/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Mar 24, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 25, 2019
@BridgeAR BridgeAR mentioned this pull request Mar 25, 2019
Closed
4 tasks
@BridgeAR
Copy link
Member Author

Landed in fd992e6 🎉

@BridgeAR BridgeAR closed this Mar 27, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 27, 2019
@BridgeAR
doc: mark settings as optional and add callback
fd992e6 
The settings are currently not required and the callback was not
documented so far.

Refs: nodejs#26811

PR-URL: nodejs#26894
Refs: nodejs#26811
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@BridgeAR @targos
doc: mark settings as optional and add callback
a117007 
The settings are currently not required and the callback was not
documented so far.

Refs: nodejs#26811

PR-URL: nodejs#26894
Refs: nodejs#26811
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@BridgeAR @targos
doc: mark settings as optional and add callback
119f83b 
The settings are currently not required and the callback was not
documented so far.

Refs: #26811

PR-URL: #26894
Refs: #26811
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@BridgeAR @BethGriggs
doc: mark settings as optional and add callback
f565b25 
The settings are currently not required and the callback was not
documented so far.

Refs: #26811

PR-URL: #26894
Refs: #26811
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR deleted the mark-settings-optional branch January 20, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BridgeAR @nodejs-github-bot @jasnell @lpinca