build: remove unused label from vcbuild.bat #26901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the :wix-not-found label and harmonize the spelling of "WiX".
nodejs-github-bot
added
build
cjihrig
approved these changes
Mar 25, 2019
BridgeAR
approved these changes
Mar 25, 2019
BridgeAR
added
the
author ready
BethGriggs
approved these changes
Mar 25, 2019
richardlau
approved these changes
Mar 27, 2019
There was a problem hiding this comment.
For reference, the goto that referenced :wix-not-found was removed in #16969.
|
Landed in 534d0dc |
targos
pushed a commit
that referenced
this pull request
Mar 30, 2019
Remove the :wix-not-found label and harmonize the spelling of "WiX". PR-URL: #26901 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 5, 2019
Remove the :wix-not-found label and harmonize the spelling of "WiX". PR-URL: #26901 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 9, 2019
Remove the :wix-not-found label and harmonize the spelling of "WiX". PR-URL: #26901 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the :wix-not-found label and harmonize the spelling of "WiX".