Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: add ws: and wss: to slashedProtocol set #26941

Closed
wants to merge 1 commit into from
Closed

url: add ws: and wss: to slashedProtocol set #26941

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Mar 27, 2019

Fix cases where the pathname is incorrectly parsed as null.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@lpinca
url: add ws: and wss: to slashedProtocol set
20fb558 
Fix cases where the pathname is incorrectly parsed as `null`.
@nodejs-github-bot
Copy link
Collaborator

@lpinca build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3066/pipeline

@nodejs-github-bot nodejs-github-bot added the url Issues and PRs related to the legacy built-in url module. label Mar 27, 2019
@lpinca
Copy link
Member Author

lpinca commented Mar 27, 2019

The legacy URL API is deprecated but I think bug fixes are still accepted? url.parse() is heavily used.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/21965/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 28, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/21976/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/21980/

@targos
Copy link
Member

targos commented Mar 30, 2019

Landed in 6a34b85

@targos targos closed this Mar 30, 2019
targos pushed a commit that referenced this pull request Mar 30, 2019
@lpinca @targos
url: add ws: and wss: to slashedProtocol set
6a34b85 
Fix cases where the pathname is incorrectly parsed as `null`.

PR-URL: #26941
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@lpinca lpinca deleted the fix/ws-pathname branch March 30, 2019 13:40
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@lpinca @BethGriggs
url: add ws: and wss: to slashedProtocol set
472e8e4 
Fix cases where the pathname is incorrectly parsed as `null`.

PR-URL: #26941
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 8, 2019
@lpinca @BethGriggs
url: add ws: and wss: to slashedProtocol set
8798db3 
Fix cases where the pathname is incorrectly parsed as `null`.

PR-URL: #26941
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Merged
@lpinca lpinca mentioned this pull request Nov 10, 2019
Closed
3 tasks
lpinca added a commit to lpinca/node that referenced this pull request Nov 10, 2019
@lpinca
doc: add entry to url.parse() changes metadata
77885ff 
Document that returned `pathname` is now `/` when the URL to parse has
no path and the protocol scheme is`ws:` or `wss:`.

Fixes: nodejs#30154
Refs: nodejs#26941
lpinca added a commit that referenced this pull request Nov 15, 2019
@lpinca
doc: add entry to url.parse() changes metadata
04e45db 
Document that returned `pathname` is now `/` when the URL to parse has
no path and the protocol scheme is`ws:` or `wss:`.

PR-URL: #30348
Fixes: #30154
Refs: #26941
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
@lpinca @MylesBorins
doc: add entry to url.parse() changes metadata
e4a296c 
Document that returned `pathname` is now `/` when the URL to parse has
no path and the protocol scheme is`ws:` or `wss:`.

PR-URL: #30348
Fixes: #30154
Refs: #26941
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Dec 1, 2019
@lpinca @targos
doc: add entry to url.parse() changes metadata
1ef1f4f 
Document that returned `pathname` is now `/` when the URL to parse has
no path and the protocol scheme is`ws:` or `wss:`.

PR-URL: #30348
Fixes: #30154
Refs: #26941
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@lpinca @MylesBorins
doc: add entry to url.parse() changes metadata
d979a9d 
Document that returned `pathname` is now `/` when the URL to parse has
no path and the protocol scheme is`ws:` or `wss:`.

PR-URL: #30348
Fixes: #30154
Refs: #26941
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihalskiy mihalskiy mihalskiy approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lpinca @nodejs-github-bot @targos @cjihrig @BridgeAR @ZYSzys @mihalskiy