process: patch more process properties during pre-execution #26945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
This gets rid of Environment::ExecutionMode as well now that we use the original arguments to determine execution mode.
Delay the creation of process properties that depend on runtime states and properties that should not be accessed during bootstrap and patch them during pre-execution: - process.argv - process.execPath - process.title - process.pid - process.ppid - process.REVERT_* - process.debugPort
joyeecheung
force-pushed
the
patch-process
branch
from
f9c38ee
to
f44207b
Compare
|
@nodejs/process Can I have some reviews please? Thanks! |
|
Pinging reviewers suggested by GitHub.. @bnoordhuis @addaleax @guybedford PTAL |
devsnek
approved these changes
Apr 3, 2019
BridgeAR
added
the
author ready
benjamingr
approved these changes
Apr 3, 2019
|
Landed in 10eaf6a...9dba96d |
joyeecheung
added a commit
that referenced
this pull request
Apr 3, 2019
This gets rid of Environment::ExecutionMode as well now that we use the original arguments to determine execution mode. PR-URL: #26945 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
joyeecheung
added a commit
that referenced
this pull request
Apr 3, 2019
Delay the creation of process properties that depend on runtime states and properties that should not be accessed during bootstrap and patch them during pre-execution: - process.argv - process.execPath - process.title - process.pid - process.ppid - process.REVERT_* - process.debugPort PR-URL: #26945 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 4, 2019
This gets rid of Environment::ExecutionMode as well now that we use the original arguments to determine execution mode. PR-URL: #26945 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 4, 2019
Delay the creation of process properties that depend on runtime states and properties that should not be accessed during bootstrap and patch them during pre-execution: - process.argv - process.execPath - process.title - process.pid - process.ppid - process.REVERT_* - process.debugPort PR-URL: #26945 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 9, 2019
This gets rid of Environment::ExecutionMode as well now that we use the original arguments to determine execution mode. PR-URL: #26945 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 10, 2019
This gets rid of Environment::ExecutionMode as well now that we use the original arguments to determine execution mode. PR-URL: #26945 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process: store argv in Environment
This gets rid of Environment::ExecutionMode as well now that
we use the original arguments to determine execution mode.
process: patch more process properties during pre-execution
Delay the creation of process properties that depend on
runtime states and properties that should not be accessed
during bootstrap and patch them during pre-execution:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes