src: check uv_fs_close() return value #26967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cjihrig Sadly, an error occurred when I tried to trigger a build. :( |
nodejs-github-bot
added
the
c++
addaleax
approved these changes
Mar 28, 2019
BridgeAR
added
the
author ready
|
CI: https://ci.nodejs.org/job/node-test-pull-request/21997/ EDIT(cjihrig): CI was yellow. |
richardlau
approved these changes
Mar 28, 2019
bnoordhuis
approved these changes
Mar 29, 2019
Coverity was complaining about not checking the return value. PR-URL: nodejs#26967 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 5, 2019
Coverity was complaining about not checking the return value. PR-URL: #26967 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverity was complaining about not checking the return value.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes