Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: js2c.py use ==/!= to compare str, bytes, and int literals #26979

Closed
wants to merge 5 commits into from
Closed

tools: js2c.py use ==/!= to compare str, bytes, and int literals #26979

wants to merge 5 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Mar 29, 2019 •
edited by refack
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Mar 29, 2019
@refack
Copy link
Contributor

refack commented Mar 29, 2019

Refs: F632

@refack refack added the python PRs and issues that require attention from people who are familiar with Python. label Mar 29, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@refack
Copy link
Contributor

refack commented Mar 29, 2019

/CC @nodejs/python

@refack
Copy link
Contributor

refack commented Mar 29, 2019

@cclauss you can ignore Travis.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 31, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@joyeecheung joyeecheung mentioned this pull request Apr 2, 2019
Closed
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22356/

@BridgeAR
Copy link
Member

This requires a rebase.

@refack
Copy link
Contributor

refack commented Apr 15, 2019

Essentially superseded by #25518

@cclauss
Copy link
Contributor Author

cclauss commented Apr 15, 2019

Closing in favor of #25518

@cclauss cclauss closed this Apr 15, 2019
@cclauss cclauss deleted the patch-3 branch April 15, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cclauss @refack @nodejs-github-bot @BridgeAR @thefourtheye @richardlau