buffer: fix custom inspection with extra properties #27074
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This broke due to a recent change that prevents exposing inspect internals. It now relies on the public API instead and should be a bit more robust due to that.
nodejs-github-bot
added
buffer
targos
approved these changes
Apr 3, 2019
BridgeAR
added
the
author ready
|
@nodejs/util @nodejs/buffer PTAL |
|
This could use another review :) |
ZYSzys
reviewed
Apr 7, 2019
ZYSzys
approved these changes
Apr 8, 2019
danbev
pushed a commit
to danbev/node
that referenced
this pull request
Apr 8, 2019
This broke due to a recent change that prevents exposing inspect internals. It now relies on the public API instead and should be a bit more robust due to that. PR-URL: nodejs#27074 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
|
Landed in d834275. |
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke due to a recent change that prevents exposing inspect
internals. It now relies on the public API instead and should be a
bit more "robust" due to that (it's still bad but I see no good alternative :D).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes