Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: always use diagnostic file sequence number #27142

Merged
merged 1 commit into from
Apr 11, 2019
Merged

src: always use diagnostic file sequence number #27142

merged 1 commit into from
Apr 11, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 8, 2019

This commit attaches a sequence number to all filenames that are automatically generated by DiagnosticFilename. This prevents accidental overwriting of existing files.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3203

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report. labels Apr 8, 2019
richardlau
richardlau approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the sequence number shared across all uses of MakeFilename(), including those that use different prefix's and/or ext's. I'm okay with it (although it feels a bit odd) but I'll point it out in case others feel differently.

@cjihrig
Copy link
Contributor Author

cjihrig commented Apr 8, 2019

This makes the sequence number shared across all uses of MakeFilename(), including those that use different prefix's and/or ext's.

Yes, I was aware of that as well. I don't think we need to overcomplicate this. If someone wants a custom filename, they can pass in a custom filename. Thanks for pointing it out though.

mhdawson
mhdawson approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22285/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 9, 2019 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/22301/

EDIT(cjihrig): CI was green.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 9, 2019
@joyeecheung joyeecheung mentioned this pull request Apr 9, 2019
Closed
4 tasks
@cjihrig
src: always use diagnostic file sequence number
547576f 
This commit attaches a sequence number to all filenames that
are automatically generated by DiagnosticFilename. This prevents
accidental overwriting of existing files.

PR-URL: nodejs#27142
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@cjihrig cjihrig merged commit 547576f into nodejs:master Apr 11, 2019
@cjihrig cjihrig deleted the diag-file-seq branch April 11, 2019 00:43
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @nodejs-github-bot @jasnell @addaleax @richardlau @BridgeAR @mhdawson