Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: assign missed deprecation code #27164

Merged
merged 1 commit into from
Apr 10, 2019
Merged

doc: assign missed deprecation code #27164

merged 1 commit into from
Apr 10, 2019

Conversation

richardlau
Copy link
Member

Spotted while reviewing the v11.14.0 proposal.

Refs: #26982

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3221

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Apr 9, 2019
This was referenced Apr 9, 2019
Merged
Closed
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@richardlau richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 10, 2019
@richardlau
doc: assign missed deprecation code
f1ab837 
Refs: nodejs#26982

PR-URL: nodejs#27164
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@richardlau richardlau self-assigned this Apr 10, 2019
@richardlau
Copy link
Member Author

Landed in f1ab837.

@richardlau richardlau merged commit f1ab837 into nodejs:master Apr 10, 2019
BethGriggs pushed a commit that referenced this pull request Apr 10, 2019
@richardlau @BethGriggs
doc: assign missed deprecation code
75e8377 
Refs: #26982

PR-URL: #27164
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@richardlau richardlau deleted the deprecations branch April 14, 2019 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees

@richardlau richardlau

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richardlau @nodejs-github-bot @vsemozhetbyt @ZYSzys