test: test privateEncrypt/publicDecrypt + padding #27188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verify that RSA_NO_PADDING and RSA_PKCS1_PADDING work as advertised.
cjihrig
approved these changes
Apr 11, 2019
sam-github
approved these changes
Apr 11, 2019
danbev
approved these changes
Apr 12, 2019
|
New CI, old one had infra issues: https://ci.nodejs.org/job/node-test-pull-request/22418/ |
|
Landed in 2fed83d. |
danbev
pushed a commit
that referenced
this pull request
Apr 15, 2019
Verify that RSA_NO_PADDING and RSA_PKCS1_PADDING work as advertised. PR-URL: #27188 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify that RSA_NO_PADDING and RSA_PKCS1_PADDING work as advertised.