-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: mark some known flakes #27193
Merged
Merged
test: mark some known flakes #27193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refack
added
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
fast-track
PRs that do not need to wait for 48 hours to land.
labels
Apr 11, 2019
I move this should be fast tracked, please 👍 here if you concur. |
Trott
approved these changes
Apr 11, 2019
richardlau
approved these changes
Apr 11, 2019
PR-URL: nodejs#27193 Refs: nodejs#20750 Refs: nodejs#26610 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
refack
force-pushed
the
mark-some-flakes
branch
from
April 11, 2019 19:43
4808bf1
to
abe4183
Compare
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fast-track
PRs that do not need to wait for 48 hours to land.
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #20750
Refs: #26610
@nodejs/testing PTAL
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes