Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build,win: bail vcbuild if mklink fails #27216

Merged
merged 1 commit into from
Apr 20, 2019
Merged

build,win: bail vcbuild if mklink fails #27216

merged 1 commit into from
Apr 20, 2019

Conversation

refack
Copy link
Contributor

@refack refack commented Apr 13, 2019

Refs: #27149 (comment)

Otherwise vcbuild will continue even if mklink fails, and will use old artifacts if present.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3243

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Apr 13, 2019
@refack refack requested a review from richardlau April 13, 2019 14:12
@refack refack force-pushed the bail-vcbuild-if-mklink-fails branch from 772c4db to 1a39749 Compare April 13, 2019 14:16
refack
refack commented Apr 13, 2019
View reviewed changes
vcbuild.bat Outdated Show resolved Hide resolved
@nodejs nodejs deleted a comment from nodejs-github-bot Apr 13, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22412/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22414/

@refack refack self-assigned this Apr 13, 2019
@refack refack force-pushed the bail-vcbuild-if-mklink-fails branch from b09360b to b72f24e Compare April 14, 2019 17:20
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22431/

@refack
Copy link
Contributor Author

refack commented Apr 14, 2019

/CC @nodejs/build-files @nodejs/platform-windows

@refack refack added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 14, 2019
@refack
build,win: bail vcbuild if mklink fails
0fc27f6 
PR-URL: nodejs#27216
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@refack refack force-pushed the bail-vcbuild-if-mklink-fails branch from b72f24e to 0fc27f6 Compare April 20, 2019 15:05
@refack refack merged commit 0fc27f6 into nodejs:master Apr 20, 2019
@refack refack removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 20, 2019
@refack refack removed their assignment Apr 20, 2019
@refack refack deleted the bail-vcbuild-if-mklink-fails branch April 20, 2019 15:07
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@refack @nodejs-github-bot @richardlau