src: use RAII to manage the main isolate data #27220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
joyeecheung
commented
Apr 14, 2019
| isolate_ = | ||
| NewIsolate(¶ms, event_loop, per_process::v8_platform.Platform()); | ||
| CHECK_NOT_NULL(isolate_); | ||
| isolate_data_.reset(CreateIsolateData(isolate_, |
There was a problem hiding this comment.
When implementing snapshot this needs to be changed to something like DeserializeIsolateData() which uses GetDataFromSnapshotOnce() (instead of doing e.g. String::NewFromOneByte).
| isolate_->GetHeapProfiler()->StartTrackingHeapObjects(true); | ||
| } | ||
|
|
||
| Local<Context> context = NewContext(isolate_); |
There was a problem hiding this comment.
When implementing snapshot this needs to be changed to Context::FromSnapshot() and skips RunBootstrapping() below. The Environment construction would also need to be changed in order to deserialize per-Environment data.
addaleax
approved these changes
Apr 14, 2019
jasnell
approved these changes
Apr 15, 2019
This patch encapsulates the main isolate management into a NodeMainInstance class that manages the resources with RAII and controls the Isolate::CreateParams (which is necessary for deserializing snapshots with external references)
joyeecheung
added
the
author ready
joyeecheung
commented
Apr 15, 2019
danbev
approved these changes
Apr 16, 2019
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Apr 16, 2019
bnoordhuis
approved these changes
Apr 16, 2019
| *exit_code = 1; | ||
| } | ||
|
|
||
| return env; |
There was a problem hiding this comment.
I know it's existing behavior but *exit_code isn't assigned on the happy path. It works because the caller sets it to zero before calling this method but still...
There was a problem hiding this comment.
It's an out parameter so at least in my understanding it's fine to not override in the happy path (think of it as overriding an default, whichever the default might be). But I guess with the current implementation resetting it to 0 at the beginning does not hurt either..
2 tasks
|
Landed in cab1dc5 |
joyeecheung
added a commit
that referenced
this pull request
Apr 16, 2019
This patch encapsulates the main isolate management into a NodeMainInstance class that manages the resources with RAII and controls the Isolate::CreateParams (which is necessary for deserializing snapshots with external references) PR-URL: #27220 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This was referenced Apr 23, 2019
This was referenced Apr 23, 2019
2 tasks
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Nov 1, 2019
This function was not actually available during any part of the Node 12 release line because it had been removed earlier (likely accidentally). Refs: nodejs#27220
addaleax
added a commit
that referenced
this pull request
Nov 5, 2019
This function was not actually available during any part of the Node 12 release line because it had been removed earlier (likely accidentally). Refs: #27220 PR-URL: #30098 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
This function was not actually available during any part of the Node 12 release line because it had been removed earlier (likely accidentally). Refs: #27220 PR-URL: #30098 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
This function was not actually available during any part of the Node 12 release line because it had been removed earlier (likely accidentally). Refs: #27220 PR-URL: #30098 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
This function was not actually available during any part of the Node 12 release line because it had been removed earlier (likely accidentally). Refs: #27220 PR-URL: #30098 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch encapsulates the main isolate management into a
NodeMainInstance class that manages the resources with RAII
and controls the Isolate::CreateParams (which is necessary
for deserializing snapshots with external references)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes