Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: do not require JS Context for napi_async_destroy() #27255

Closed
wants to merge 4 commits into from
Closed

n-api: do not require JS Context for napi_async_destroy() #27255

wants to merge 4 commits into from

Commits on Apr 16, 2019

  1. src: add Environment overload of EmitAsyncDestroy 

    This can be necessary for being able to call the function when no
JS Context is on the stack, e.g. during GC.

Refs: nodejs#27218
    @addaleax
    addaleax committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    7947f48 View commit details
    Browse the repository at this point in the history

  2. n-api: do not require JS Context for napi_async_destroy() 

    Allow the function to be called during GC, which is a common use case.

Fixes: nodejs#27218
    @addaleax
    addaleax committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    4128307 View commit details
    Browse the repository at this point in the history

  3. src: do not require JS Context for ~AsyncResoure() 

    Allow the destructor to be called during GC,
which is a common use case.
    @addaleax
    addaleax committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    66f6944 View commit details
    Browse the repository at this point in the history

  4. fixup! n-api: do not require JS Context for napi_async_destroy()

    @addaleax
    addaleax committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    f880b4f View commit details
    Browse the repository at this point in the history