Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct ABI entry for electron v4.0.4 #27394

Closed
wants to merge 1 commit into from
Closed

fix: correct ABI entry for electron v4.0.4 #27394

wants to merge 1 commit into from

Commits on Apr 24, 2019

  1. fix: correct entry for electron v4.0.4 

    `abi_version_registry.json` incorrectly specified that electron v4.0.4 used `NODE_MODULE_VERSION` 64, but in fact it uses 69.

See:

* electron/electron#16687
* https://github.com/electron/electron/releases/tag/v4.0.4
* electron/node-abi@9e4c1a6
    @jacobq
    jacobq authored Apr 24, 2019
    Configuration menu
    Copy the full SHA
    90f7ebd View commit details
    Browse the repository at this point in the history