core: throw TypeError if chdir() args don't match signature #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| assert.throws('process.chdir({})', TypeError, 'Bad argument.'); | ||
| assert.throws('process.chdir()', TypeError, 'Bad argument.'); | ||
| assert.throws('process.chdir("x", "y")', TypeError, 'Bad argument.'); |
There was a problem hiding this comment.
This is both a V8-ism that works by accident and a bug in the assert module... assert.throws() calls the first argument as a function. The result is a TypeError when the input is a string but it doesn't seem to check that the exception message matches...
There was a problem hiding this comment.
is that right, let me take a look at the assert module quickly
There was a problem hiding this comment.
yeah, looks like it :) I'll just rearrange those
|
@caitp Can you update the commit log so that the first line <= 50 characters? |
caitp
force-pushed
the
make-it-a-typeerror-okay
branch
from
d6d9cff
to
f8666bf
Compare
bnoordhuis
pushed a commit
that referenced
this pull request
Jan 9, 2015
PR-URL: #274 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Thanks Caitlin, landed in be2404e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little stab at #264. I'm doing my part!
The compat risk for changing this is pretty low. (there are a lot of other APIs implemented in C++ which should be changed in the same way)