Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: backport ICU-20558 to fix Intl crasher #27415

Closed
wants to merge 2 commits into from
Closed

deps: backport ICU-20558 to fix Intl crasher #27415

wants to merge 2 commits into from

Commits on Apr 25, 2019

  1. deps: backport ICU-20558 to fix Intl crasher 

    - Floating patch for ICU 63.x and 64.x
- fixing crash in Intl when ICU data not found.
- Regression test from refack included.

Background:
- ICU-13778 (landed in ICU 63.1) fixed a bug but
added a regression.
- a recent v8 land in Node v12 (which one?) exposes
this bug to cause a crash when ICU data is not found.

ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20558
Backport of: unicode-org/icu#632
(Commit not landed yet in ICU)
Fixes: nodejs#27379
Co-authored-by: Refael Ackermann <refack@gmail.com>
    @srl295 @refack
    srl295 and refack committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    c369ef0 View commit details
    Browse the repository at this point in the history

  2. fixup! Some platforms need the full env

    @refack
    refack committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    d93152d View commit details
    Browse the repository at this point in the history