Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add missing --trace in man page #27528

Closed
wants to merge 2 commits into from
Closed

Conversation

monperrus
Copy link

alternative to #27510

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 2, 2019
doc/node.1 Outdated Show resolved Hide resolved
Co-Authored-By: monperrus <monperrus@users.noreply.github.com>
@Trott
Copy link
Member

Trott commented May 2, 2019

No opinion on whether or not we should add this, but I imagine that if we should, then we should also add it to doc/api/cli.md?

Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not document these. There was in fact a discussion around preventing users to use most of these flags by switching to a whitelist to limit the possible flags to V8.

// cc @hashseed

@BridgeAR
Copy link
Member

@nodejs/v8 PTAL

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are intentionally undocumented.

@Trott
Copy link
Member

Trott commented May 19, 2019

That's two Collaborators opposed to documenting these types of flags, and none advocating for it, so I'm going to close this out. But feel free to comment or re-open if you think that's premature of me.

@monperrus Thanks for the pull request! I hope this has not been dispiriting and that we might see more contributions from you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants