build: export OpenSSL UI symbols #27586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
addaleax
added
openssl
addaleax
approved these changes
May 6, 2019
richardlau
approved these changes
May 6, 2019
tniessen
approved these changes
May 6, 2019
Trott
approved these changes
May 6, 2019
|
I think |
Node.js compiles them, their existence is indicated by OpenSSL header defines, but they can't be linked to on Windows because their symbols are not exported. Export them. Fixes: nodejs#27494
sam-github
force-pushed
the
export-openssl-ui-symbols
branch
from
4e40c1d to
666a13d
Compare
mscdex
changed the title
cjihrig
approved these changes
May 7, 2019
|
Looks good. This matches the change I made when testing. |
lpinca
approved these changes
May 7, 2019
|
Landed in b9a3103 |
sam-github
added a commit
that referenced
this pull request
May 9, 2019
Node.js compiles them, their existence is indicated by OpenSSL header defines, but they can't be linked to on Windows because their symbols are not exported. Export them. Fixes: #27494 PR-URL: #27586 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos
pushed a commit
that referenced
this pull request
May 10, 2019
Node.js compiles them, their existence is indicated by OpenSSL header defines, but they can't be linked to on Windows because their symbols are not exported. Export them. Fixes: #27494 PR-URL: #27586 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js compiles them, their existence is indicated by OpenSSL header
defines, but they can't be linked to on Windows because their symbols
are not exported. Export them.
Fixes: #27494
See #27494 (comment) for more info.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes