doc: dns.lookup() documentation error code #27625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dns.lookup() will always return ENOTFOUND on a empty lookup or when the host not found. https://github.com/nodejs/node/blob/master/lib/internal/errors.js#L503 Fixes: #27604
nodejs-github-bot
added
dns
mihalskiy
approved these changes
May 9, 2019
What about (from the docs) |
Trott
approved these changes
May 10, 2019
Trott
added
the
author ready
jasnell
approved these changes
May 10, 2019
I experimented and seemed to get ENOTFOUND in that situation too. #27604 (comment) |
|
Landed in fd8d5e7 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 13, 2019
dns.lookup() will always return ENOTFOUND on a empty lookup or when the host not found. https://github.com/nodejs/node/blob/master/lib/internal/errors.js#L503 Fixes: nodejs#27604 PR-URL: nodejs#27625 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 14, 2019
dns.lookup() will always return ENOTFOUND on a empty lookup or when the host not found. https://github.com/nodejs/node/blob/master/lib/internal/errors.js#L503 Fixes: #27604 PR-URL: #27625 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dns.lookup() will always return ENOTFOUND on a empty lookup
or when the host not found.
https://github.com/nodejs/node/blob/master/lib/internal/errors.js#L503
Fixes: #27604
make -j4 test(UNIX), orvcbuild test(Windows) passes