Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: setup stdio on error when possible #27696

Merged
merged 1 commit into from
May 20, 2019
Merged

child_process: setup stdio on error when possible #27696

merged 1 commit into from
May 20, 2019

Commits on May 20, 2019

  1. child_process: setup stdio on error when possible 

    As more spawn() errors are classified as runtime errors, it's
no longer appropriate to only check UV_ENOENT when determining
if stdio can be setup. This commit reverses the check to look
for EMFILE and ENFILE specifically.

PR-URL: nodejs#27696
Fixes: nodejs#26852
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @cjihrig
    cjihrig committed May 20, 2019
    Configuration menu
    Copy the full SHA
    64182e9 View commit details
    Browse the repository at this point in the history