Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick cca9ae3c9a #27729

Closed
wants to merge 1 commit into from
Closed

Commits on May 16, 2019

  1. deps: V8: cherry-pick cca9ae3c9a

    Original commit message:
    
        Remove recursion from NeedsCheckHeapObject.
    
        We use the predicate NeedsCheckHeapObject in the compiler frontend to
        determine whether we can skip introducing CheckHeapObject nodes. But
        this predicate would also walk up the graph in case of Phis, which can
        result in really long compilation times (on the main thread). In the
        report in nodejs#27667, the compiler
        frontend alone took around 4-5mins of main thread time for a single
        function. With this patch the time goes down to 4-5ms.
    
        Bug: v8:9250
        Refs: nodejs#27667
        Change-Id: I231eb780ff04f949fa1669714f9af6ebfbcade05
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1612897
        Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
        Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#61503}
    
    Fixes: nodejs#27667
    bmeurer authored and bnoordhuis committed May 16, 2019
    Configuration menu
    Copy the full SHA
    5176a79 View commit details
    Browse the repository at this point in the history