src: allow --interpreted-frames-native-stack in NODE_OPTIONS #27744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
the
c++
This comment has been minimized.
This comment has been minimized.
richardlau
approved these changes
May 17, 2019
addaleax
approved these changes
May 17, 2019
cjihrig
approved these changes
May 17, 2019
Trott
reviewed
May 17, 2019
doc/api/cli.md
Outdated
| @@ -932,6 +932,7 @@ V8 options that are allowed are: | |||
| - `--perf-basic-prof-only-functions` | |||
| - `--perf-prof` | |||
| - `--perf-prof-unwinding-info` | |||
| - `--interpreted-frames-native-stack` | |||
There was a problem hiding this comment.
The flags are currently in alphabetical order. Can you move this one to line 930 to maintain alphabetical listing? Or is it better that it be below --perf-* flags?
Trott
approved these changes
May 17, 2019
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
May 18, 2019
BridgeAR
approved these changes
May 21, 2019
addaleax
added
the
author ready
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@mmarchini this needs a rebase. |
BridgeAR
removed
the
author ready
|
I'll rebase and address @Trott in the next few days. |
|
Small bump @mmarchini ? :) |
mmarchini
force-pushed
the
ifnt-node-options
branch
from
61e2daa to
59fd2ba
Compare
mmarchini
force-pushed
the
ifnt-node-options
branch
from
59fd2ba to
f078ea1
Compare
mmarchini
added a commit
that referenced
this pull request
Aug 27, 2019
PR-URL: #27744 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in 0150490 🎉 Thank you for the reviews and sorry for the delay! |
BridgeAR
pushed a commit
that referenced
this pull request
Sep 3, 2019
PR-URL: #27744 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 4, 2019
PR-URL: #27744 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have
--perf-basic-profand family in NODE_OPTIONS, but these flags might not give the desired result without--interpreted-frames-native-stack, thus adding this flag in NODE_OPTIONS as well makes sense.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes