-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: correct parameter type on 'subprocess.kill([signal])' #27760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
child_process
Issues and PRs related to the child_process subsystem.
doc
Issues and PRs related to the documentations.
labels
May 18, 2019
node/lib/internal/child_process.js Lines 461 to 486 in 030fa2e
|
cjihrig
approved these changes
May 18, 2019
jasnell
approved these changes
May 18, 2019
lpinca
approved these changes
May 19, 2019
ZYSzys
approved these changes
May 19, 2019
himself65
changed the title
docs: correct parameter type on 'subprocess.kill([signal])'
doc: correct parameter type on 'subprocess.kill([signal])'
May 19, 2019
ZYSzys
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
May 20, 2019
trivikr
approved these changes
May 20, 2019
Landed in 2e5bc80 🎉 |
pull bot
pushed a commit
to tkamenoko/node
that referenced
this pull request
May 20, 2019
PR-URL: nodejs#27760 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
May 21, 2019
PR-URL: #27760 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
child_process
Issues and PRs related to the child_process subsystem.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #27750
Checklist