tls: destroy trace BIO instead of leaking it #27834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
c++
jasnell
approved these changes
May 23, 2019
bnoordhuis
approved these changes
May 23, 2019
addaleax
approved these changes
May 23, 2019
This comment has been minimized.
This comment has been minimized.
cjihrig
approved these changes
May 23, 2019
This comment has been minimized.
This comment has been minimized.
sam-github
force-pushed
the
fix-tls-trace-leak
branch
from
f88db7d to
797aaf0
Compare
This comment has been minimized.
This comment has been minimized.
sam-github
force-pushed
the
fix-tls-trace-leak
branch
from
797aaf0 to
c3c03a0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sam-github
force-pushed
the
fix-tls-trace-leak
branch
from
e6ef2af to
c3c03a0
Compare
Trott
approved these changes
May 25, 2019
|
Landed in 725a66a :) |
addaleax
pushed a commit
that referenced
this pull request
May 26, 2019
Fixes: #27636 (comment) PR-URL: #27834 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 28, 2019
Fixes: #27636 (comment) PR-URL: #27834 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #27636 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes