src: export number_of_native_contexts and number_of_detached_contexts #27933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
export number_of_native_contexts and number_of_detached_contexts as part of v8.getHeapStatistics()
nodejs-github-bot
added
c++
addaleax
approved these changes
May 28, 2019
addaleax
added
the
semver-minor
joyeecheung
approved these changes
May 28, 2019
Co-Authored-By: Anna Henningsen <github@addaleax.net>
bnoordhuis
approved these changes
May 28, 2019
Co-Authored-By: Anna Henningsen <github@addaleax.net>
cjihrig
approved these changes
May 29, 2019
Trott
approved these changes
May 30, 2019
This comment has been minimized.
This comment has been minimized.
Trott
added
the
author ready
|
I've checked failed checks and its looks like random failures which can not be related to the current pull request:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 30, 2019
export number_of_native_contexts and number_of_detached_contexts as part of v8.getHeapStatistics() PR-URL: nodejs#27933 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in a40aae8. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
targos
pushed a commit
that referenced
this pull request
May 31, 2019
export number_of_native_contexts and number_of_detached_contexts as part of v8.getHeapStatistics() PR-URL: #27933 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
added a commit
that referenced
this pull request
Jun 3, 2019
Notable changes:
* doc:
* The JSON variant of the API documentation is no longer experimental
(Rich Trott) #27842.
* esm:
* JSON module support is always enabled under
`--experimental-modules`. The `--experimental-json-modules` flag
has been removed (Myles Borins)
#27752.
* http,http2:
* A new flag has been added for overriding the default HTTP server
socket timeout (which is two minutes). Pass
`--http-server-default-timeout=milliseconds`
or `--http-server-default-timeout=0` to respectively change or
disable the timeout. Starting with Node.js 13.0.0, the timeout will
be disabled by default
(Ali Ijaz Sheikh) #27704.
* inspector:
* Added an experimental `--heap-prof` flag to start the V8 heap
profiler on startup and write the heap profile to disk before exit
(Joyee Cheung) #27596.
* stream:
* The `readable.unshift()` method now correctly converts strings to
buffers. Additionally, a new optional argument is accepted to
specify the string's encoding, such as `'utf8'` or `'ascii'`
(Marcos Casagrande) #27194.
* v8:
* The object returned by `v8.getHeapStatistics()` has two new
properties: `number_of_native_contexts` and
`number_of_detached_contexts` (Yuriy Vasiyarov)
#27933.
PR-URL: #28040
pull bot
pushed a commit
to Rachelmorrell/node
that referenced
this pull request
Jun 4, 2019
Notable changes:
* doc:
* The JSON variant of the API documentation is no longer experimental
(Rich Trott) nodejs#27842.
* esm:
* JSON module support is always enabled under
`--experimental-modules`. The `--experimental-json-modules` flag
has been removed (Myles Borins)
nodejs#27752.
* http,http2:
* A new flag has been added for overriding the default HTTP server
socket timeout (which is two minutes). Pass
`--http-server-default-timeout=milliseconds`
or `--http-server-default-timeout=0` to respectively change or
disable the timeout. Starting with Node.js 13.0.0, the timeout will
be disabled by default
(Ali Ijaz Sheikh) nodejs#27704.
* inspector:
* Added an experimental `--heap-prof` flag to start the V8 heap
profiler on startup and write the heap profile to disk before exit
(Joyee Cheung) nodejs#27596.
* stream:
* The `readable.unshift()` method now correctly converts strings to
buffers. Additionally, a new optional argument is accepted to
specify the string's encoding, such as `'utf8'` or `'ascii'`
(Marcos Casagrande) nodejs#27194.
* v8:
* The object returned by `v8.getHeapStatistics()` has two new
properties: `number_of_native_contexts` and
`number_of_detached_contexts` (Yuriy Vasiyarov)
nodejs#27933.
PR-URL: nodejs#28040
ghost
deleted a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
export number_of_native_contexts and number_of_detached_contexts as
part of v8.getHeapStatistics()
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes