Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] async_hooks: avoid double-destroy HTTPParser #27986

Closed
wants to merge 1 commit into from
Closed

[v10.x] async_hooks: avoid double-destroy HTTPParser #27986

wants to merge 1 commit into from

Commits on May 30, 2019

  1. async_hooks: avoid double-destroy HTTPParser 

    Avoid that destroy hook is invoked twice - once via `Parser::Free()`
and once again via `Parser::Reinitialize()` by clearing the async_id
in `EmitDestroy()`.

Partial backport of nodejs#27477, a full
backport would require also nodejs#25094
which has a dont-land-on-v10.x label on it.

Fixes: nodejs#26961
    @Flarna
    Flarna committed May 30, 2019
    Configuration menu
    Copy the full SHA
    35283e7 View commit details
    Browse the repository at this point in the history