test: rename worker MessagePort test #28024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All other tests for message ports use the `-` in between `message` and `port`. This is annoying when using tab completion for filenames.
addaleax
added
test
targos
approved these changes
Jun 2, 2019
Trott
approved these changes
Jun 2, 2019
Trott
added
the
author ready
cjihrig
approved these changes
Jun 2, 2019
ZYSzys
approved these changes
Jun 3, 2019
richardlau
approved these changes
Jun 3, 2019
trivikr
approved these changes
Jun 3, 2019
BridgeAR
approved these changes
Jun 4, 2019
|
Landed in 52b6d39. |
ZYSzys
pushed a commit
to zys-contrib/node
that referenced
this pull request
Jun 5, 2019
All other tests for message ports use the `-` in between `message` and `port`. This is annoying when using tab completion for filenames. PR-URL: nodejs#28024 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
All other tests for message ports use the `-` in between `message` and `port`. This is annoying when using tab completion for filenames. PR-URL: #28024 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other tests for message ports use the
-in betweenmessageandport. This is annoying when using tab completionfor filenames.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes