Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make sure vtable is generated in addon test with LTO #28057

Closed
wants to merge 1 commit into from
Closed

test: make sure vtable is generated in addon test with LTO #28057

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Jun 4, 2019

Fixes: #28026

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax addaleax mentioned this pull request Jun 4, 2019
Closed
4 tasks
@addaleax addaleax added addons Issues and PRs related to native addons. c++ Issues and PRs that require attention from people who are familiar with C++. test Issues and PRs related to the tests. labels Jun 4, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23614/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23619/

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 4, 2019
@danbev
Copy link
Contributor

danbev commented Jun 7, 2019

Landed in b31bfad.

@danbev danbev closed this Jun 7, 2019
danbev pushed a commit that referenced this pull request Jun 7, 2019
@addaleax @danbev
test: make sure vtable is generated in addon test with LTO
b31bfad 
PR-URL: #28057
Fixes: #28026
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@addaleax @BridgeAR
test: make sure vtable is generated in addon test with LTO
87e977a 
PR-URL: #28057
Fixes: #28026
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test: abort/test-addon-uv-handle-leak failure when LTO is enabled
5 participants
@addaleax @nodejs-github-bot @danbev @cjihrig @richardlau