Revert 27962 #28083
Closed
Revert 27962 #28083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 39d6da8.
This reverts commit 2abaa1a.
This reverts commit f212fee.
This reverts commit 3e5b20c.
This reverts commit 7aa79be.
This reverts commit c49e378.
This reverts commit 6925f41.
This reverts commit b422561.
This reverts commit 6adeae6.
This reverts commit 5d08697.
This reverts commit b250085.
This reverts commit 198162a.
This reverts commit c420972.
This reverts commit f5e6ac2.
This reverts commit 56d3383.
This reverts commit ee00111.
This reverts commit 8091df0.
2 tasks
|
I suggest this be fast-tracked when it passes CI, it fixes test failures introduced in #27962 Please thumbs-up this if you agree. |
sam-github
added
the
fast-track
ofrobots
approved these changes
Jun 5, 2019
|
As a heads-up, I won't be available for a couple hours to land this, so if it gets some fasttrack votes and passes CI, anyone who has the time feel free to land it. |
trivikr
approved these changes
Jun 5, 2019
refack
approved these changes
Jun 5, 2019
refack
pushed a commit
to refack/node
that referenced
this pull request
Jun 5, 2019
PR-URL: nodejs#28083 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
|
Fast-track landed in 965ffc4 |
|
https://ci.nodejs.org/job/node-test-commit/29189/ ✔️ Re running CI since there seems to get some git whitespace artifacts when rebasing. test/fixtures/msca.pem | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/test/fixtures/msca.pem b/test/fixtures/msca.pem
index 247368e625..82ae5e1bec 100644
--- a/test/fixtures/msca.pem
+++ b/test/fixtures/msca.pem
CRLF->LF
test/fixtures/foafssl.key | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/fixtures/foafssl.key b/test/fixtures/foafssl.key
index 62e953a67f..facbec5541 100644
--- a/test/fixtures/foafssl.key
+++ b/test/fixtures/foafssl.key
@@ -1,6 +1,6 @@
Bag Attributes
friendlyName: Me's Not a Certification Authority ID
- localKeyID: 98 CC 02 91 83 8D 14 4A 60 40 B7 11 E8 EF A9 01 4B D7 16 8A
+ localKeyID: 98 CC 02 91 83 8D 14 4A 60 40 B7 11 E8 EF A9 01 4B D7 16 8A
Key Attributes: <No Attributes>
-----BEGIN PRIVATE KEY-----
MIIEvwIBADANBgkqhkiG9w0BAQEFAASCBKkwggSlAgEAAoIBAQCm9EqcJXkUMSFP
test/fixtures/foafssl.crt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/fixtures/foafssl.crt b/test/fixtures/foafssl.crt
index f4b5905e37..4a95dcd714 100644
--- a/test/fixtures/foafssl.crt
+++ b/test/fixtures/foafssl.crt
@@ -1,6 +1,6 @@
Bag Attributes
friendlyName: Me's Not a Certification Authority ID
- localKeyID: 98 CC 02 91 83 8D 14 4A 60 40 B7 11 E8 EF A9 01 4B D7 16 8A
+ localKeyID: 98 CC 02 91 83 8D 14 4A 60 40 B7 11 E8 EF A9 01 4B D7 16 8A
subject=/O=FOAF+SSL/OU=The Community Of Self Signers/UID=http://example.com/#me/CN=Me
issuer=/O=FOAF+SSL/OU=The Community of Self Signers/CN=Not a Certification Authority
-----BEGIN CERTIFICATE----- |
|
thanks @refack |
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
PR-URL: #28083 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes