test: add github refs to flaky tests #28123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sadly, an error occurred when I tried to trigger a build. :( |
nodejs-github-bot
added
test
sam-github
force-pushed
the
add-flaky-github-refs
branch
from
5477cea to
afa54b2
Compare
richardlau
approved these changes
Jun 7, 2019
Trott
approved these changes
Jun 8, 2019
BethGriggs
approved these changes
Jun 10, 2019
jasnell
approved these changes
Jun 10, 2019
cjihrig
approved these changes
Jun 10, 2019
|
Landed in b17a70f |
sam-github
added a commit
that referenced
this pull request
Jun 10, 2019
PR-URL: #28123 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
PR-URL: #28123 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See nodejs/reliability#1, I'm trying to get the info on flakes correct.
I also adjusted platform labels for the issues, though that can't be seen in this PR, and added a platform label for Linux, since one was missing and there were some Linux flakes.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes