New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove unnecessary bind #28131

Closed

apapirovski wants to merge 5 commits into nodejs:master from apapirovski:remove-unnecessary-bind

Member

apapirovski commented Jun 8, 2019

There has been a lot of effort on the V8 side to optimize bind performance but nonetheless it's still unnecessary overhead in many cases. Removing it can also make the resulting code more readable as the implied scope isn't immediately apparent when reading certain functions.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

This comment has been minimized.

Sign in to view

nodejs-github-bot added the lib / src label

This comment has been minimized.

Sign in to view

apapirovski force-pushed the remove-unnecessary-bind branch from 9c884b8 to e51c91c Compare

June 8, 2019 08:35

Collaborator

nodejs-github-bot commented Jun 8, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23712/

lpinca reviewed

View reviewed changes

lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved

lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved

lib/internal/timers.js Outdated Show resolved Hide resolved

Collaborator

nodejs-github-bot commented Jun 8, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23713/

lpinca approved these changes

View reviewed changes

jasnell approved these changes

View reviewed changes

cjihrig approved these changes

View reviewed changes

Trott approved these changes

View reviewed changes

Member

addaleax commented Aug 25, 2019

ping @apapirovski :)

Trott force-pushed the master branch from 1ecc406 to 49cf67e Compare

September 17, 2019 16:51

tniessen approved these changes

View reviewed changes

apapirovski added 3 commits

December 13, 2019 15:21


          http: remove unnecessary bind

62b955d

process.nextTick accepts additional parameters which
are passed through to the callback. Use that instead
of binding the function to a context.


          perf_hooks: remove unnecessary bind

96067ca

Pass through parameters using setImmediate rather
than using Function.prototype.bind to bind the
provided context.


          fs: remove unnecessary bind

396e428

Don't use Function.prototype.bind where it isn't
necessary. Rely on event emitter context instead
and on arrow function as class property.

apapirovski force-pushed the remove-unnecessary-bind branch from e51c91c to c7a87fa Compare

December 13, 2019 20:25

Member Author

apapirovski commented Dec 13, 2019 •

edited

Loading

Well, this is a blast from the past. Thought I merged it...

CI: https://ci.nodejs.org/job/node-test-pull-request/27650/

apapirovski force-pushed the remove-unnecessary-bind branch from c7a87fa to 193f0c2 Compare

December 13, 2019 20:31

Collaborator

nodejs-github-bot commented Dec 13, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27638/

apapirovski added 2 commits

December 13, 2019 16:39


          http2: remove unnecessary bind from setImmediate

a560c73


          cluster: remove unnecessary bind

d077f00

apapirovski force-pushed the remove-unnecessary-bind branch from 193f0c2 to d077f00 Compare

December 13, 2019 21:39

Collaborator

nodejs-github-bot commented Dec 13, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27650/

BridgeAR approved these changes

View reviewed changes

Collaborator

nodejs-github-bot commented Dec 14, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27669/

Member

Trott commented Dec 14, 2019

Landed in e17403e...2e738fb

Trott pushed a commit that referenced this pull request


          http: remove unnecessary bind

fea1f1c

process.nextTick accepts additional parameters which
are passed through to the callback. Use that instead
of binding the function to a context.

PR-URL: #28131
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Trott pushed a commit that referenced this pull request


          perf_hooks: remove unnecessary bind

Pass through parameters using setImmediate rather
than using Function.prototype.bind to bind the
provided context.

PR-URL: #28131
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins pushed a commit that referenced this pull request


          perf_hooks: remove unnecessary bind

4e67d38

Pass through parameters using setImmediate rather
than using Function.prototype.bind to bind the
provided context.

PR-URL: #28131
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins pushed a commit that referenced this pull request


          fs: remove unnecessary bind

ad5b715

Don't use Function.prototype.bind where it isn't
necessary. Rely on event emitter context instead
and on arrow function as class property.

PR-URL: #28131
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins pushed a commit that referenced this pull request


          http2: remove unnecessary bind from setImmediate

52aab47

PR-URL: #28131
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins pushed a commit that referenced this pull request


          cluster: remove unnecessary bind

30e2d28

PR-URL: #28131
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins mentioned this pull request

v13.5.0 proposal #31010

Merged

targos pushed a commit that referenced this pull request


          http: remove unnecessary bind

baece55

process.nextTick accepts additional parameters which
are passed through to the callback. Use that instead
of binding the function to a context.

PR-URL: #28131
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos pushed a commit that referenced this pull request


          perf_hooks: remove unnecessary bind

01bb876

Pass through parameters using setImmediate rather
than using Function.prototype.bind to bind the
provided context.

PR-URL: #28131
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos pushed a commit that referenced this pull request


          fs: remove unnecessary bind

91845d8

Don't use Function.prototype.bind where it isn't
necessary. Rely on event emitter context instead
and on arrow function as class property.

PR-URL: #28131
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos pushed a commit that referenced this pull request


          http2: remove unnecessary bind from setImmediate

dce435d

PR-URL: #28131
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos pushed a commit that referenced this pull request


          cluster: remove unnecessary bind

f76f143

PR-URL: #28131
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos mentioned this pull request

v12.15.0 release proposal #31368

Closed

BethGriggs pushed a commit that referenced this pull request


          http: remove unnecessary bind

8111d69

process.nextTick accepts additional parameters which
are passed through to the callback. Use that instead
of binding the function to a context.

PR-URL: #28131
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BethGriggs pushed a commit that referenced this pull request


          perf_hooks: remove unnecessary bind

25ba7f4

Pass through parameters using setImmediate rather
than using Function.prototype.bind to bind the
provided context.

PR-URL: #28131
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BethGriggs pushed a commit that referenced this pull request


          fs: remove unnecessary bind

cc9712d

Don't use Function.prototype.bind where it isn't
necessary. Rely on event emitter context instead
and on arrow function as class property.

PR-URL: #28131
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BethGriggs pushed a commit that referenced this pull request


          http2: remove unnecessary bind from setImmediate

84603ec

PR-URL: #28131
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BethGriggs pushed a commit that referenced this pull request


          cluster: remove unnecessary bind

2d23502

PR-URL: #28131
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins mentioned this pull request

v12.16.0 proposal #31691

Merged

kissofire mentioned this pull request

[Snyk] Fix for 1 vulnerabilities kissofire/node#73

Open

wedataintelligence mentioned this pull request

[Snyk] Fix for 1 vulnerabilities wedataintelligence/node#38

Open

ron-a20 mentioned this pull request

[Snyk] Fix for 1 vulnerabilities ron-a20/node#71

Open

Dmarch28 mentioned this pull request

[Snyk] Fix for 1 vulnerabilities Dmarch28/node#62

Open

aliceUnhinged613 mentioned this pull request

[Snyk] Fix for 1 vulnerabilities aliceUnhinged613/node#64

Open

137717unity mentioned this pull request

[Snyk] Fix for 1 vulnerabilities 137717unity/node#62

Open

baby636 mentioned this pull request

[Snyk] Fix for 1 vulnerabilities baby636/node#61

Open

molllyn1 mentioned this pull request

[Snyk] Fix for 1 vulnerabilities molllyn1/node#53

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes

BridgeAR BridgeAR approved these changes

tniessen tniessen approved these changes

cjihrig cjihrig approved these changes

lpinca lpinca approved these changes

jasnell jasnell approved these changes

Labels