Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document behavior of family:0 in dns.lookup() #28163

Closed
wants to merge 1 commit into from
Closed

doc: document behavior of family:0 in dns.lookup() #28163

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jun 11, 2019

Fixes: #28159

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 11, 2019 •
edited
Loading

Sadly, an error occurred when I tried to trigger a build. :(
CI: https://ci.nodejs.org/job/node-test-pull-request/23829/
CI: https://ci.nodejs.org/job/node-test-pull-request/23833/

@nodejs-github-bot nodejs-github-bot added dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. labels Jun 11, 2019
@ZYSzys
Copy link
Member

ZYSzys commented Jun 14, 2019

Landed in 282e2f6.

@ZYSzys ZYSzys closed this Jun 14, 2019
@ZYSzys ZYSzys mentioned this pull request Jun 14, 2019
Closed
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@cjihrig @BridgeAR
doc: document behavior of family:0 in dns.lookup()
3780683 
Fixes: #28159

PR-URL: #28163
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
Merged
targos pushed a commit that referenced this pull request Jun 18, 2019
@cjihrig @targos
doc: document behavior of family:0 in dns.lookup()
4cadddc 
Fixes: #28159

PR-URL: #28163
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig deleted the dns-docs branch June 19, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dns docs are missing that family = 0 for dns.lookup is allowed
8 participants
@cjihrig @nodejs-github-bot @ZYSzys @jasnell @Trott @lpinca @richardlau @BridgeAR