tools: enable no-unused-vars linter rule and fix issues

.eslintrc

@@ -78,6 +78,8 @@ rules:
   # list: https://github.com/eslint/eslint/tree/master/docs/rules#variables
   ## disallow use of undefined variables (globals)
   no-undef: 2
+  ## disallow unused variables
+  no-unused-vars: [2, {vars: "all", args: "none"}]
 
   # Custom rules in tools/eslint-rules
   require-buffer: 2

lib/_http_client.js

@@ -3,7 +3,6 @@
 const util = require('util');
 const net = require('net');
 const url = require('url');
-const EventEmitter = require('events').EventEmitter;
 const HTTPParser = process.binding('http_parser').HTTPParser;
 const assert = require('assert').ok;
 const common = require('_http_common');

lib/internal/repl.js

@@ -14,12 +14,6 @@ module.exports.createInternalRepl = createRepl;
 // The debounce is to guard against code pasted into the REPL.
 const kDebounceHistoryMS = 15;
 
-// XXX(chrisdickinson): hack to make sure that the internal debugger
-// uses the original repl.
-function replStart() {
-  return REPL.start.apply(REPL, arguments);
-}
-
 function createRepl(env, opts, cb) {
   if (typeof opts === 'function') {
     cb = opts;

lib/os.js

@@ -1,7 +1,6 @@
 'use strict';
 
 const binding = process.binding('os');
-const util = require('util');
 const internalUtil = require('internal/util');
 const isWindows = process.platform === 'win32';
 

test/addons/at-exit/test.js

@@ -1,2 +1,2 @@
 'use strict';
-var binding = require('./build/Release/binding');
+require('./build/Release/binding');

test/addons/repl-domain-abort/test.js

@@ -41,4 +41,4 @@ var options = {
 };
 
 // Run commands from fake REPL.
-var dummy = repl.start(options);
+repl.start(options);

test/debugger/test-debugger-pid.js

@@ -1,16 +1,8 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var spawn = require('child_process').spawn;
 
-var port = common.PORT + 1337;
 var buffer = '';
-var expected = [];
-var scriptToDebug = common.fixturesDir + '/empty.js';
-
-function fail() {
-  assert(0); // `--debug-brk script.js` should not quit
-}
 
 // connect to debug agent
 var interfacer = spawn(process.execPath, ['debug', '-p', '655555']);

test/debugger/test-debugger-remote.js

@@ -3,9 +3,7 @@ var common = require('../common');
 var assert = require('assert');
 var spawn = require('child_process').spawn;
 
-var port = common.PORT + 1337;
 var buffer = '';
-var expected = [];
 var scriptToDebug = common.fixturesDir + '/empty.js';
 
 function fail() {

test/internet/test-dns-txt-sigsegv.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var dns = require('dns');
 

test/internet/test-dns.js

@@ -3,7 +3,6 @@ var common = require('../common');
 var assert = require('assert'),
     dns = require('dns'),
     net = require('net'),
-    isIP = net.isIP,
     isIPv4 = net.isIPv4,
     isIPv6 = net.isIPv6;
 var util = require('util');
@@ -117,7 +116,7 @@ TEST(function test_reverse_bogus(done) {
   var error;
 
   try {
-    var req = dns.reverse('bogus ip', function() {
+    dns.reverse('bogus ip', function() {
       assert.ok(false);
     });
   } catch (e) {
@@ -716,7 +715,7 @@ console.log('looking up nodejs.org...');
 
 var cares = process.binding('cares_wrap');
 var req = new cares.GetAddrInfoReqWrap();
-var err = cares.getaddrinfo(req, 'nodejs.org', 4);
+cares.getaddrinfo(req, 'nodejs.org', 4);
 
 req.oncomplete = function(err, domains) {
   assert.strictEqual(err, 0);

test/internet/test-http-dns-fail.js

@@ -4,7 +4,6 @@
  * should trigger the error event after each attempt.
  */
 
-var common = require('../common');
 var assert = require('assert');
 var http = require('http');
 

test/internet/test-net-connect-timeout.js

@@ -3,7 +3,6 @@
 // https://groups.google.com/forum/#!topic/nodejs/UE0ZbfLt6t8
 // https://groups.google.com/forum/#!topic/nodejs-dev/jR7-5UDqXkw
 
-var common = require('../common');
 var net = require('net');
 var assert = require('assert');
 

test/internet/test-net-connect-unref.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var net = require('net');
 

test/message/2100bytes.js

@@ -1,7 +1,4 @@
 'use strict';
-var common = require('../common');
-var assert = require('assert');
-var util = require('util');
 
 console.log([
   '_______________________________________________50',

test/message/error_exit.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 process.on('exit', function(code) {

test/message/eval_messages.js

@@ -1,8 +1,5 @@
 'use strict';
 
-var common = require('../common');
-var assert = require('assert');
-
 var spawn = require('child_process').spawn;
 
 function run(cmd, strict, cb) {

test/message/hello_world.js

@@ -1,5 +1,3 @@
 'use strict';
-var common = require('../common');
-var assert = require('assert');
 
 console.log('hello world');

test/message/max_tick_depth.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 
 process.maxTickDepth = 10;
 var i = 20;

test/message/nexttick_throw.js

@@ -1,6 +1,4 @@
 'use strict';
-var common = require('../common');
-var assert = require('assert');
 
 process.nextTick(function() {
   process.nextTick(function() {

test/message/stack_overflow.js

@@ -1,6 +1,4 @@
 'use strict';
-var common = require('../common');
-var assert = require('assert');
 
 Error.stackTraceLimit = 0;
 

test/message/stdin_messages.js

@@ -1,8 +1,5 @@
 'use strict';
 
-var common = require('../common');
-var assert = require('assert');
-
 var spawn = require('child_process').spawn;
 
 function run(cmd, strict, cb) {

test/message/throw_custom_error.js

@@ -1,6 +1,4 @@
 'use strict';
-var common = require('../common');
-var assert = require('assert');
 
 // custom error throwing
 throw ({ name: 'MyCustomError', message: 'This is a custom message' });

test/message/throw_custom_error.out

@@ -1,4 +1,4 @@
-*test*message*throw_custom_error.js:6
+*test*message*throw_custom_error.js:4
 throw ({ name: 'MyCustomError', message: 'This is a custom message' });
 ^
 MyCustomError: This is a custom message

test/message/throw_in_line_with_tabs.js

@@ -1,7 +1,5 @@
 /* eslint-disable indent */
 'use strict';
-var common = require('../common');
-var assert = require('assert');
 
 console.error('before');
 

test/message/throw_in_line_with_tabs.out

@@ -1,5 +1,5 @@
 before
-*test*message*throw_in_line_with_tabs.js:10
+*test*message*throw_in_line_with_tabs.js:8
 	throw ({ foo: 'bar' });
 	^
 [object Object]

test/message/throw_non_error.js

@@ -1,6 +1,4 @@
 'use strict';
-var common = require('../common');
-var assert = require('assert');
 
 // custom error throwing
 throw ({ foo: 'bar' });

test/message/throw_non_error.out

@@ -1,4 +1,4 @@
-*test*message*throw_non_error.js:6
+*test*message*throw_non_error.js:4
 throw ({ foo: 'bar' });
 ^
 [object Object]

test/message/throw_null.js

@@ -1,5 +1,3 @@
 'use strict';
-var common = require('../common');
-var assert = require('assert');
 
 throw null;

test/message/throw_null.out

@@ -1,5 +1,5 @@
 
-*test*message*throw_null.js:5
+*test*message*throw_null.js:3
 throw null;
 ^
 null

test/message/throw_undefined.js

@@ -1,5 +1,3 @@
 'use strict';
-var common = require('../common');
-var assert = require('assert');
 
 throw undefined;

test/message/throw_undefined.out

@@ -1,5 +1,5 @@
 
-*test*message*throw_undefined.js:5
+*test*message*throw_undefined.js:3
 throw undefined;
 ^
 undefined

test/message/timeout_throw.js

@@ -1,6 +1,4 @@
 'use strict';
-var common = require('../common');
-var assert = require('assert');
 
 setTimeout(function() {
   undefined_reference_error_maker;

test/message/undefined_reference_in_new_context.js

@@ -1,6 +1,4 @@
 'use strict';
-var common = require('../common');
-var assert = require('assert');
 var vm = require('vm');
 
 console.error('before');

test/message/vm_display_runtime_error.js

@@ -1,6 +1,4 @@
 'use strict';
-var common = require('../common');
-var assert = require('assert');
 var vm = require('vm');
 
 console.error('beginning');

test/message/vm_display_syntax_error.js

@@ -1,6 +1,4 @@
 'use strict';
-var common = require('../common');
-var assert = require('assert');
 var vm = require('vm');
 
 console.error('beginning');

test/message/vm_dont_display_runtime_error.js

@@ -1,6 +1,4 @@
 'use strict';
-var common = require('../common');
-var assert = require('assert');
 var vm = require('vm');
 
 console.error('beginning');

test/message/vm_dont_display_syntax_error.js

@@ -1,6 +1,4 @@
 'use strict';
-var common = require('../common');
-var assert = require('assert');
 var vm = require('vm');
 
 console.error('beginning');

test/parallel/test-assert.js

@@ -273,8 +273,6 @@ assert.throws(makeBlock(a.deepStrictEqual, new Boolean(true), {}),
 function thrower(errorConstructor) {
   throw new errorConstructor('test');
 }
-var aethrow = makeBlock(thrower, a.AssertionError);
-aethrow = makeBlock(thrower, a.AssertionError);
 
 // the basic calls work
 assert.throws(makeBlock(thrower, a.AssertionError),

test/parallel/test-beforeexit-event.js

@@ -1,7 +1,6 @@
 'use strict';
 var assert = require('assert');
 var net = require('net');
-var util = require('util');
 var common = require('../common');
 var revivals = 0;
 var deaths = 0;

test/parallel/test-buffer-arraybuffer.js

@@ -1,8 +1,6 @@
 'use strict';
 
-const common = require('../common');
 const assert = require('assert');
-
 const Buffer = require('buffer').Buffer;
 const LENGTH = 16;
 

test/parallel/test-buffer-ascii.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 // ASCII conversion in node.js simply masks off the high bits,

test/parallel/test-buffer-bytelength.js

@@ -1,6 +1,5 @@
 'use strict';
 
-var common = require('../common');
 var assert = require('assert');
 var Buffer = require('buffer').Buffer;
 

test/parallel/test-buffer-concat.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 var zero = [];

test/parallel/test-buffer-fakes.js

@@ -1,9 +1,7 @@
 'use strict';
 
-const common = require('../common');
 const assert = require('assert');
 const Buffer = require('buffer').Buffer;
-const Bp = Buffer.prototype;
 
 function FakeBuffer() { }
 FakeBuffer.__proto__ = Buffer;

test/parallel/test-buffer-indexof.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 var Buffer = require('buffer').Buffer;

test/parallel/test-buffer-inspect.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 var util = require('util');

test/parallel/test-buffer-iterator.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 var buffer = new Buffer([1, 2, 3, 4, 5]);

test/parallel/test-buffer-slow.js

@@ -1,6 +1,5 @@
 'use strict';
 
-const common = require('../common');
 const assert = require('assert');
 const buffer = require('buffer');
 const Buffer = buffer.Buffer;

test/parallel/test-child-process-buffering.js

@@ -2,8 +2,6 @@
 var common = require('../common');
 var assert = require('assert');
 
-var spawn = require('child_process').spawn;
-
 var pwd_called = false;
 var childClosed = false;
 var childExited = false;

test/parallel/test-child-process-constructor.js

@@ -1,7 +1,6 @@
 'use strict';
 
 var assert = require('assert');
-var common = require('../common');
 var child_process = require('child_process');
 var ChildProcess = child_process.ChildProcess;
 assert.equal(typeof ChildProcess, 'function');