deps: V8: extend workaround for MSVC optimizer bug #28286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
v8 engine
|
I would like to fast-track this because this issue is blocking the release of v12.5.0. Please 👍 this comment if you agree. |
Merged
bzoz
approved these changes
Jun 19, 2019
This comment has been minimized.
This comment has been minimized.
cjihrig
approved these changes
Jun 19, 2019
refack
approved these changes
Jun 19, 2019
This comment has been minimized.
This comment has been minimized.
Not objecting to this PR but the referenced url (https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html) seems to reference VS2019 while the failing link for 12.5.0 is VS2017: https://ci.nodejs.org/job/node-compile-windows/27287/label=win-vs2017/. The error also doesn't look the same: 10:35:50 c:\workspace\node-compile-windows\deps\v8\include\v8-platform.h(381): note: see declaration of 'v8::Platform::CallDelayedOnForegroundThread'
10:36:20 [4932] Failed to execute script clcache_main
10:36:20 Traceback (most recent call last):
10:36:20 File "clcache_main.py", line 2, in <module>
10:36:20 File "clcache\__main__.py", line 1666, in main
10:36:20 File "clcache\__main__.py", line 1693, in processCompileRequest
10:36:20 File "clcache\__main__.py", line 1751, in scheduleJobs
10:36:20 File "clcache\__main__.py", line 1479, in cleanCache
10:36:20 File "contextlib.py", line 112, in __enter__
10:36:20 File "clcache\__main__.py", line 558, in lock
10:36:20 File "contextlib.py", line 112, in __enter__
10:36:20 File "clcache\__main__.py", line 221, in allSectionsLocked
10:36:20 File "clcache\__main__.py", line 370, in acquire
10:36:20 clcache.__main__.CacheLockException: Failed to acquire lock Local\C--Users-Administrator-clcache-manifests-00 after 30000ms; try setting CLCACHE_OBJECT_CACHE_TIMEOUT_MS environment variable to a larger value.
10:36:20 C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(314,5): error MSB6006: "cl.exe" exited with code -1. [c:\workspace\node-compile-windows\cctest.vcxproj] |
It seems like the same issue is triggering timeouts with MSVS2017 as well. |
This comment has been minimized.
This comment has been minimized.
BridgeAR
approved these changes
Jun 19, 2019
Builds are starting to fail in CI with V8 7.5 and 7.6. Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html PR-URL: nodejs#28286 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
approved these changes
Jun 19, 2019
targos
added a commit
that referenced
this pull request
Jun 20, 2019
Builds are starting to fail in CI with V8 7.5 and 7.6. Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html PR-URL: #28286 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds are starting to fail in CI with V8 7.5 and 7.6.
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html