test: preloading common module in tests

test/common.js

@@ -247,6 +247,12 @@ var knownGlobals = [setTimeout,
                     process,
                     global];
 
+/*
+ * Exporting this, because we can add additional purposefully leaked stuff if
+ * the test needs.
+ */
+exports.knownGlobals = knownGlobals;
+
 if (global.gc) {
   knownGlobals.push(gc);
 }

test/fixtures/common-detect-global-leak.js

@@ -0,0 +1 @@
+leak_this_to_global_space = 1

test/internet/test-dns-txt-sigsegv.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var dns = require('dns');
 

test/internet/test-http-dns-fail.js

@@ -4,7 +4,6 @@
  * should trigger the error event after each attempt.
  */
 
-var common = require('../common');
 var assert = require('assert');
 var http = require('http');
 

test/internet/test-net-connect-timeout.js

@@ -3,7 +3,6 @@
 // https://groups.google.com/forum/#!topic/nodejs/UE0ZbfLt6t8
 // https://groups.google.com/forum/#!topic/nodejs-dev/jR7-5UDqXkw
 
-var common = require('../common');
 var net = require('net');
 var assert = require('assert');
 

test/internet/test-net-connect-unref.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var net = require('net');
 

test/message/2100bytes.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var util = require('util');
 

test/message/error_exit.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 process.on('exit', function(code) {

test/message/eval_messages.js

@@ -1,6 +1,5 @@
 'use strict';
 
-var common = require('../common');
 var assert = require('assert');
 
 var spawn = require('child_process').spawn;

test/message/hello_world.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 console.log('hello world');

test/message/max_tick_depth.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 
 process.maxTickDepth = 10;
 var i = 20;

test/message/nexttick_throw.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 process.nextTick(function() {

test/message/stack_overflow.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 Error.stackTraceLimit = 0;

test/message/stdin_messages.js

@@ -1,6 +1,5 @@
 'use strict';
 
-var common = require('../common');
 var assert = require('assert');
 
 var spawn = require('child_process').spawn;

test/message/throw_custom_error.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 // custom error throwing

test/message/throw_custom_error.out

@@ -1,4 +1,4 @@
-*test*message*throw_custom_error.js:6
+*test*message*throw_custom_error.js:5
 throw ({ name: 'MyCustomError', message: 'This is a custom message' });
 ^
 MyCustomError: This is a custom message

test/message/throw_in_line_with_tabs.js

@@ -1,6 +1,5 @@
 /* eslint-disable indent */
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 console.error('before');

test/message/throw_in_line_with_tabs.out

@@ -1,5 +1,5 @@
 before
-*test*message*throw_in_line_with_tabs.js:10
+*test*message*throw_in_line_with_tabs.js:9
 	throw ({ foo: 'bar' });
 	^
 [object Object]

test/message/throw_non_error.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 // custom error throwing

test/message/throw_non_error.out

@@ -1,4 +1,4 @@
-*test*message*throw_non_error.js:6
+*test*message*throw_non_error.js:5
 throw ({ foo: 'bar' });
 ^
 [object Object]

test/message/throw_null.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 throw null;

test/message/throw_null.out

@@ -1,5 +1,5 @@
 
-*test*message*throw_null.js:5
+*test*message*throw_null.js:4
 throw null;
 ^
 null

test/message/throw_undefined.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 throw undefined;

test/message/throw_undefined.out

@@ -1,5 +1,5 @@
 
-*test*message*throw_undefined.js:5
+*test*message*throw_undefined.js:4
 throw undefined;
 ^
 undefined

test/message/timeout_throw.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 setTimeout(function() {

test/message/undefined_reference_in_new_context.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var vm = require('vm');
 

test/message/vm_display_runtime_error.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var vm = require('vm');
 

test/message/vm_display_syntax_error.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var vm = require('vm');
 

test/message/vm_dont_display_runtime_error.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var vm = require('vm');
 

test/message/vm_dont_display_syntax_error.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var vm = require('vm');
 

test/parallel/test-buffer-arraybuffer.js

@@ -1,6 +1,5 @@
 'use strict';
 
-const common = require('../common');
 const assert = require('assert');
 
 const Buffer = require('buffer').Buffer;

test/parallel/test-buffer-ascii.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 // ASCII conversion in node.js simply masks off the high bits,

test/parallel/test-buffer-bytelength.js

@@ -1,6 +1,5 @@
 'use strict';
 
-var common = require('../common');
 var assert = require('assert');
 var Buffer = require('buffer').Buffer;
 

test/parallel/test-buffer-concat.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 var zero = [];

test/parallel/test-buffer-fakes.js

@@ -1,6 +1,5 @@
 'use strict';
 
-const common = require('../common');
 const assert = require('assert');
 const Buffer = require('buffer').Buffer;
 const Bp = Buffer.prototype;

test/parallel/test-buffer-indexof.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 var Buffer = require('buffer').Buffer;

test/parallel/test-buffer-inspect.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 var util = require('util');

test/parallel/test-buffer-iterator.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 var buffer = new Buffer([1, 2, 3, 4, 5]);

test/parallel/test-buffer-slow.js

@@ -1,6 +1,5 @@
 'use strict';
 
-const common = require('../common');
 const assert = require('assert');
 const buffer = require('buffer');
 const Buffer = buffer.Buffer;

test/parallel/test-child-process-constructor.js

@@ -1,7 +1,6 @@
 'use strict';
 
 var assert = require('assert');
-var common = require('../common');
 var child_process = require('child_process');
 var ChildProcess = child_process.ChildProcess;
 assert.equal(typeof ChildProcess, 'function');

test/parallel/test-child-process-detached.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var path = require('path');
 

test/parallel/test-child-process-fork-and-spawn.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var spawn = require('child_process').spawn;
 var fork = require('child_process').fork;

test/parallel/test-child-process-fork-ref.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var fork = require('child_process').fork;
 

test/parallel/test-child-process-fork-ref2.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var fork = require('child_process').fork;
 

test/parallel/test-child-process-internal.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 //messages

test/parallel/test-child-process-set-blocking.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var ch = require('child_process');
 

test/parallel/test-child-process-silent.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var childProcess = require('child_process');
 

test/parallel/test-child-process-spawnsync-env.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var cp = require('child_process');
 

test/parallel/test-child-process-spawnsync-timeout.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 var spawnSync = require('child_process').spawnSync;

test/parallel/test-child-process-stdin-ipc.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 
 var spawn = require('child_process').spawn;

test/parallel/test-child-process-stdio-big-write-end.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var BUFSIZE = 1024;
 

test/parallel/test-child-process-validate-stdio.js

@@ -2,7 +2,6 @@
 // Flags: --expose_internals
 
 var assert = require('assert');
-var common = require('../common');
 var _validateStdio = require('internal/child_process')._validateStdio;
 
 // should throw if string and not ignore, pipe, or inherit

test/parallel/test-cli-eval.js

@@ -5,8 +5,7 @@ if (module.parent) {
   process.exit(42);
 }
 
-var common = require('../common'),
-    assert = require('assert'),
+var assert = require('assert'),
     child = require('child_process'),
     nodejs = '"' + process.execPath + '"';
 

test/parallel/test-cluster-debug-port.js

@@ -1,10 +1,14 @@
 'use strict';
-const common = require('../common');
 const assert = require('assert');
 const cluster = require('cluster');
 
 if (cluster.isMaster) {
-  assert.strictEqual(process.execArgv.length, 0, 'run test with no args');
+  /*
+   * By default, the `-r` and `./test/common` will be passed, to preload common
+   * module. So, we are making sure that no other arguments are passed.
+   */
+  assert.strictEqual(process.execArgv.length, 2, 'run test with no args');
+  assert.deepStrictEqual(process.execArgv, ['-r', './test/common']);
 
   function checkExitCode(code, signal) {
     assert.strictEqual(code, 0);

test/parallel/test-cluster-fork-env.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var cluster = require('cluster');
 

test/parallel/test-cluster-net-listen.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var cluster = require('cluster');
 var net = require('net');

test/parallel/test-cluster-setup-master-argv.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var cluster = require('cluster');
 

test/parallel/test-cluster-setup-master-cumulative.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var cluster = require('cluster');
 

test/parallel/test-cluster-setup-master-emit.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var cluster = require('cluster');
 

test/parallel/test-cluster-setup-master-multiple.js

@@ -1,5 +1,4 @@
 'use strict';
-var common = require('../common');
 var assert = require('assert');
 var cluster = require('cluster');