doc: add example function isDead to cluster #28362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[x] documentation is changed or added
nodejs-github-bot
added
cluster
Trott
reviewed
Jun 21, 2019
Trott
reviewed
Jun 21, 2019
Trott
reviewed
Jun 21, 2019
|
@nodejs/documentation |
Trott
previously requested changes
Jun 21, 2019
There was a problem hiding this comment.
Welcome @jessecogollo and thanks for the pull request! It may be possible to simplify/shorten this one a bit? It's probably fine the way it is though? I'm not sure so I pinged the documentation team. Thanks again!
|
Thank you @Trott. |
jasnell
approved these changes
Jun 23, 2019
khriztianmoreno
approved these changes
Jun 23, 2019
trivikr
reviewed
Jun 24, 2019
doc/api/cluster.md
Outdated
| process.kill(process.pid); | ||
| }).listen(8000); | ||
|
|
||
| // Make http://localhost:8000 to ckeck isDead method. |
There was a problem hiding this comment.
nit: typo
Suggested change
| // Make http://localhost:8000 to ckeck isDead method. | |
| // Make http://localhost:8000 to check isDead method. |
There was a problem hiding this comment.
"Make" means "Make a connection to" here?
Suggested change
| // Make http://localhost:8000 to ckeck isDead method. | |
| // Connect to http://localhost:8000 to check isDead(). |
Trott
approved these changes
Jun 24, 2019
trivikr
approved these changes
Jun 25, 2019
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 25, 2019
PR-URL: nodejs#28362 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in e2d445b. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
PR-URL: #28362 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] added example documentation