Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools,makefile: fix file open mode and cleanup tap file #2837

Closed
wants to merge 2 commits into from
Closed

tools,makefile: fix file open mode and cleanup tap file #2837

wants to merge 2 commits into from

Commits on Sep 13, 2015

  1. tools: open test.tap file in write-binary mode 

    By default the logfile is opened in append mode. This commit makes sure
that the file is opened in write-binary mode, so that the file will be
created if it doesn't exist or overwrite if it exists.

Fixes: nodejs#2834
    @thefourtheye
    thefourtheye committed Sep 13, 2015
    Configuration menu
    Copy the full SHA
    43e809b View commit details
    Browse the repository at this point in the history

  2. build: clean up the generated tap file 

    Make `make clean` cleanup the generated tap file as well.

Fixes: nodejs#2834
    @thefourtheye
    thefourtheye committed Sep 13, 2015
    Configuration menu
    Copy the full SHA
    89d5237 View commit details
    Browse the repository at this point in the history