Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add example of event close for child_process #28376

Closed
wants to merge 2 commits into from
Closed

doc: add example of event close for child_process #28376

wants to merge 2 commits into from

Conversation

ltciro
Copy link
Contributor

@ltciro ltciro commented Jun 21, 2019 •
edited
Loading

add a missing example of the event close for child_process

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Jun 21, 2019
@jasnell jasnell added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jun 23, 2019
jasnell
jasnell reviewed Jun 23, 2019
View reviewed changes
doc/api/child_process.md
```js
const { spawn } = require('child_process');
const ls = spawn('ls', ['-lh', '/usr']);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion for the example :-)

Suggested change
ls.stdout.setEncoding('utf8');

@Trott
Copy link
Member

Trott commented Jun 24, 2019

@nodejs/documentation This duplicates sample code from elsewhere in the doc. Is this how we want to do this sort of thing? Would a more succinct example which focuses on close be a better fit here?

@Trott
Copy link
Member

Trott commented Jul 30, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3811/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 30, 2019
@Trott
Copy link
Member

Trott commented Jul 30, 2019

Lite CI again: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3812/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24770/

@Trott
Copy link
Member

Trott commented Jul 30, 2019

Landed in 89344f5

@Trott Trott closed this Jul 30, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 30, 2019
@ltciro @Trott
doc: add example of event close for child_process
89344f5 
PR-URL: nodejs#28376
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Aug 2, 2019
@ltciro @targos
doc: add example of event close for child_process
a28db5f 
PR-URL: #28376
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Aug 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. child_process Issues and PRs related to the child_process subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ltciro @Trott @nodejs-github-bot @jasnell