test: duplicated buffer in test-stream2-writable.js #28380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Jun 22, 2019
addaleax
added
the
code-and-learn
edsadr
approved these changes
Jun 22, 2019
ZYSzys
approved these changes
Jun 22, 2019
gireeshpunathil
approved these changes
Jun 22, 2019
targos
approved these changes
Jun 22, 2019
cjihrig
approved these changes
Jun 22, 2019
BridgeAR
approved these changes
Jun 22, 2019
BridgeAR
added
the
author ready
trivikr
approved these changes
Jun 23, 2019
jasnell
approved these changes
Jun 23, 2019
Trott
approved these changes
Jun 24, 2019
|
Landed in c42da5e |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 25, 2019
PR-URL: nodejs#28380 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
PR-URL: #28380 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create constant and reuse it in three different places where it was repeated.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes