tools: enable arrow functions in .eslintrc #2840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of v8 4.5, arrow functions are rolled out. This patch allows eslint to accept arrow functions as well.
|
LGTM |
|
LGTM, but this seems way noisier than it needs to be. |
|
I am very impressed Node itself is using ESLint. |
thefourtheye
added a commit
that referenced
this pull request
Sep 15, 2015
As of v8 4.5, arrow functions are rolled out. This patch allows eslint to accept arrow functions as well. PR-URL: #2840 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Thanks for the review people :-) Landed in 845acb4 |
thefourtheye
added a commit
that referenced
this pull request
Sep 15, 2015
As of v8 4.5, arrow functions are rolled out. This patch allows eslint to accept arrow functions as well. PR-URL: #2840 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of v8 4.5, arrow functions are rolled out. This patch allows eslint
to accept arrow functions as well.
Sorted the entries as per @silverwind's suggestion in #2836 (comment)