Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation line for host:port invocation #28405

Closed
wants to merge 4 commits into from
Closed

Add documentation line for host:port invocation #28405

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d18c48
Add documentation line for host:port invocation
Jun 24, 2019
128f181
Update lib/internal/main/print_help.js
sleekweasel Jun 25, 2019
4296fa5
Remove extraneous line
sleekweasel Jun 25, 2019
dbc9f71
fixup
Trott Jul 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/main/print_help.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ function print(stream) {
options.set('--', { helpText: 'indicate the end of node options' });
stream.write(
'Usage: node [options] [ -e script | script.js | - ] [arguments]\n' +
' node inspect script.js [arguments]\n\n' +
' node inspect [script.js | -e "script" | <host>:<port>] …\n\n' +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This uses an ellipsis character (…) where everywhere else, we use three dots (...). On the one hand, the ellipsis is more correct. On the other hand, is there a situation where it will be an unprintable character because the terminal only accepts ASCII? Regardless, the code should probably pick one or the other and stick with it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter requires non-ASCII characters (to keep binary size down, believe it or not) so ... it must be.

Also, this should probably align with line 166 in that no " around script and -e comes before the script.js option.

Assuming you left the default checked state for the checkbox about allowing collaborators in this repo to push to your branch, I'll make these updates right now....

'Options:\n');
stream.write(indent(format({
options, aliases, firstColumn, secondColumn
Expand Down