doc: add description for the listener argument #28500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
silverwind
approved these changes
Jul 3, 2019
trivikr
approved these changes
Jul 3, 2019
BridgeAR
approved these changes
Jul 4, 2019
doc/api/http2.md
Outdated
| @@ -2208,7 +2208,8 @@ changes: | |||
| instance passed to `connect` and the `options` object, and returns any | |||
| [`Duplex`][] stream that is to be used as the connection for this session. | |||
| * ...: Any [`net.connect()`][] or [`tls.connect()`][] options can be provided. | |||
| * `listener` {Function} | |||
| * `listener` {Function} Will be added as a one-time listener of the | |||
There was a problem hiding this comment.
Maybe this makes it even a bit clearer?
Suggested change
| * `listener` {Function} Will be added as a one-time listener of the | |
| * `listener` {Function} Will be registered as a one-time listener of the |
ZYSzys
approved these changes
Jul 4, 2019
Clarify that `listener` is registered as a one-time listener of the `'connect'` event. Fixes: nodejs#28217
|
Landed in 8850ef2. |
lpinca
added a commit
that referenced
this pull request
Jul 6, 2019
Clarify that `listener` is registered as a one-time listener of the `'connect'` event. PR-URL: #28500 Fixes: #28217 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2019
Clarify that `listener` is registered as a one-time listener of the `'connect'` event. PR-URL: #28500 Fixes: #28217 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This was referenced Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify that
listeneris registered as a one-time listener of the'connect'event.Fixes: #28217
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes