Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use openssl_is_fips instead of hasFipsCrypto #28507

Closed
wants to merge 4 commits into from

Commits on Jul 2, 2019

  1. test: use openssl_is_fips instead of hasFipsCrypto

    Currently, when dynamically linking against a FIPS enabled OpenSSL
    library test-process-env-allowed-flags-are-documented will fail with
    the following error:
    assert.js:89
    throw new AssertionError(obj);
    ^
    
    AssertionError [ERR_ASSERTION]:
    The following options are not documented as allowed in NODE_OPTIONS in
    /root/node/doc/api/cli.md: --enable-fips --force-fips
    at Object.<anonymous>
    (/test/parallel/test-process-env-allowed-flags-are-documented.js:82:8)
    at Module._compile (internal/modules/cjs/loader.js:779:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:790:10)
    at Module.load (internal/modules/cjs/loader.js:642:32)
    at Function.Module._load (internal/modules/cjs/loader.js:555:12)
    at Function.Module.runMain (internal/modules/cjs/loader.js:842:10)
    at internal/main/run_main_module.js:17:11 {
    generatedMessage: false,
    code: 'ERR_ASSERTION',
    actual: 2,
    expected: 0,
    operator: 'strictEqual'
    }
    
    This commit updates the test to use
    process.config.variables.openssl_is_fips instead of common.hasFipsCrypto
    as hasFipsCrypto only returns true if the OpenSSL library that is
    shipped with node was configured with FIPS enabled.
    danbev committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    0d943f4 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2019

  1. Configuration menu
    Copy the full SHA
    f1e2dc6 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2019

  1. Configuration menu
    Copy the full SHA
    1d6935e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7a1fac4 View commit details
    Browse the repository at this point in the history