Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip pseudo-tty tests on AIX #28541

Closed
wants to merge 2 commits into from
Closed

test: skip pseudo-tty tests on AIX #28541

wants to merge 2 commits into from

Conversation

sam-github
Copy link
Contributor

@sam-github sam-github commented Jul 4, 2019 •
edited
Loading

See: nodejs/build#1820

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem. labels Jul 4, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24271/

mhdawson
mhdawson approved these changes Jul 4, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need to get builds back to green and we'll work to re-enable once we have a solution.

@mhdawson
Copy link
Member

mhdawson commented Jul 4, 2019

I'd like to suggest fast tracking this.

@mhdawson mhdawson added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 4, 2019
@sam-github
Copy link
Contributor Author

Landed in 8619b19

@sam-github sam-github closed this Jul 4, 2019
@sam-github sam-github deleted the skip-console-tests-on-aix branch July 4, 2019 21:49
sam-github added a commit that referenced this pull request Jul 4, 2019
@sam-github
test: skip pseudo-tty tests on AIX
8619b19 
See: nodejs/build#1820

PR-URL: #28541
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@richardlau richardlau mentioned this pull request Jul 9, 2019
Closed
targos pushed a commit that referenced this pull request Jul 20, 2019
@sam-github @targos
test: skip pseudo-tty tests on AIX
b7731eb 
See: nodejs/build#1820

PR-URL: #28541
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This was referenced Jul 23, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sam-github @nodejs-github-bot @mhdawson @richardlau