Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect link in build instructions #28572

Closed
wants to merge 1 commit into from

Conversation

GauthamBanasandra
Copy link
Contributor

#prerequesites-1 was invalid as there's no
markdown element by that name.
The right one is #prerequesites

#prerequesites-1 was invalid as there's no
markdown element by that name.
The right one is #prerequisites
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Jul 6, 2019
@Trott
Copy link
Member

Trott commented Jul 6, 2019

@Trott
Copy link
Member

Trott commented Jul 6, 2019

Collaborators, +1 to fast-track

@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Jul 6, 2019
@Trott
Copy link
Member

Trott commented Jul 6, 2019

Landed in d0e3c23

@Trott Trott closed this Jul 6, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 6, 2019
The right one is #prerequisites.

PR-URL: nodejs#28572
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@GauthamBanasandra GauthamBanasandra deleted the patch-1 branch July 6, 2019 17:14
targos pushed a commit that referenced this pull request Jul 20, 2019
The right one is #prerequisites.

PR-URL: #28572
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants