Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore missing backtick in Buffer documentation #2881

Closed
wants to merge 1 commit into from

Conversation

joepie91
Copy link
Contributor

Fixes the formatting.

@Fishrock123 Fishrock123 added the doc Issues and PRs related to the documentations. label Sep 15, 2015
@Fishrock123
Copy link
Contributor

@joepie91 Could you reformat the commit message to be something like "doc: add missing backtick in buffer.markdown`? (The "doc: " bit is the important bit!)

LGTM otherwise.

@joepie91
Copy link
Contributor Author

Hmm. I'm actually not quite sure how to do that.

Also, perhaps it'd be a good idea to add the doc: prefix to the CONTRIBUTING.md explicitly - as it only seemed to refer to code contributions, I'd decided to omit it here.

@Fishrock123
Copy link
Contributor

@joepie91 No problem. If you do git commit --amend you'll be able to edit your commit message. Then you can force-push the new commit up to here, along the lines of git push origin patch-1 --force. :)

@joepie91
Copy link
Contributor Author

Okay, should be sorted now.

Fishrock123 pushed a commit that referenced this pull request Sep 15, 2015
Fixes: #2880
PR-URL: #2881
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123
Copy link
Contributor

Thanks, landed in 360d0fa!

Fishrock123 pushed a commit that referenced this pull request Sep 15, 2015
Fixes: #2880
PR-URL: #2881
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Sep 16, 2015
7 tasks
@rvagg rvagg mentioned this pull request Sep 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants